This repository has been archived by the owner on Jun 16, 2023. It is now read-only.
fix: rename memo -> note + add bip39 mnemonic check #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serge1peshcoff
force-pushed
the
rename-memo
branch
from
a0661a9
to
7c6597d
Compare
|
Thank you for the PR. Can you please resolve the conflicts |
serge1peshcoff
force-pushed
the
rename-memo
branch
from
7c6597d
to
4760115
Compare
|
@bsrinivas8687 done. Can you check? |
serge1peshcoff
commented
May 2, 2021
| @@ -75,5 +75,8 @@ | |||
| "last 1 firefox version", | |||
| "last 1 safari version" | |||
| ] | |||
| }, | |||
| "dependencies": { | |||
There was a problem hiding this comment.
This is the only thing I'm not sure about, should it be here or in devDependencies instead? Everything else is in devDependencies, not sure why.
|
@bsrinivas8687 ping? |
|
@serge1peshcoff fix PR please |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the issue I've reported here: cosmos/cosmos-sdk#9122
Two things done:
Also refactored stuff a bit, there was some duplicated validation-related code which I've removed.
Any feedback is appreciated.