Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for autobpm plugin #98

Merged
merged 2 commits into from
Oct 7, 2023
Merged

Conversation

tandy-1000
Copy link
Contributor

I made a plugin that uses Librosa to calculate bpm automatically, it has been mainlined.
These dependencies are needed for it to work.

@sentriz sentriz merged commit 4e651fd into sentriz:master Oct 7, 2023
2 checks passed
@sentriz
Copy link
Owner

sentriz commented Oct 7, 2023

thanks👌

@sentriz
Copy link
Owner

sentriz commented Oct 25, 2023

@tandy-1000 unfortunately it seems the librosa dependancy has made the CI build blow up to 6+ hours, which then gets killed from a timeout. meaning i can't do a release

i think it must be really slow to build numbas or skikit-learn or something on armv7. any ideas?

@tandy-1000
Copy link
Contributor Author

Hmm, is anyone using armv7?

sentriz added a commit that referenced this pull request Nov 7, 2023
@tandy-1000
Copy link
Contributor Author

Can we still build arm64 though? I'm using that :D

@sentriz
Copy link
Owner

sentriz commented Nov 7, 2023

hahaha oh dear. sure, let me see if this one manages to build first though https://github.com/sentriz/betanin/actions/runs/6784481312

@tandy-1000
Copy link
Contributor Author

also, I can't seem to access to containers at ghcr.io/sentriz/betanin is that the right link?

@sentriz
Copy link
Owner

sentriz commented Nov 7, 2023

looks like even building for arm64 is horrendously slow https://github.com/sentriz/betanin/actions/runs/6786467664

@sentriz
Copy link
Owner

sentriz commented Nov 7, 2023

@tandy-1000 approaching the 6 hour limit now. it looks like compiling for any architecture other than amd64 is a no go (at least with qemu on github actions)

any ideas? can we support bpm without numbas or whatever the package is?

@sentriz
Copy link
Owner

sentriz commented Nov 8, 2023

sorry really need to get a release out so i removed librosa for now. can we build it an alternative way that wont take ages? would be happy to accept a PR. there is a new "debug-release" github action so we can see how long a build would take for a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants