Ratings support?

[sardaukar]

Is implementing ratings per track a goal?

[sentriz]

yes I would hope to do this in the future. should not be too hard. just need some time

[davidhampgonsalves]

@sentriz do you have ideas for how you plan on implementing this? I see that nicksellen/audiotags only supports read operations through taglib. Were you thinking of adding the ability to change ratings to that first?

If so it looks like https://github.com/NBonaparte/audiotags/commits/master might be a good starting point and if that is inline with your thinking I will probably take a pass at this.

[sentriz]

My idea was a track rating table instead of tags. With columns track_id, user_id, rating - to make sure ratings are per user. But I'd like to know what airsonic etc does

[davidhampgonsalves]

Looks like that's what airsonic is doing as well:

https://github.com/airsonic/airsonic/blob/828c1b2674b1b5bf4f96454ed5c154a0c074f3bb/airsonic-main/src/main/java/org/airsonic/player/controller/SetRatingController.java

I need the audio files to be the source of truth so I'll do something different.
Thanks

[sentriz]

if you follow that path:
https://github.com/airsonic/airsonic/blob/828c1b2674b1b5bf4f96454ed5c154a0c074f3bb/airsonic-main/src/main/java/org/airsonic/player/controller/SetRatingController.java#L62
->
https://github.com/airsonic/airsonic/blob/828c1b2674b1b5bf4f96454ed5c154a0c074f3bb/airsonic-main/src/main/java/org/airsonic/player/service/RatingService.java#L76
->
https://github.com/airsonic/airsonic/blob/828c1b2674b1b5bf4f96454ed5c154a0c074f3bb/airsonic-main/src/main/java/org/airsonic/player/dao/RatingDao.java#L80

they seem to be doing the same as I suggested

[davidhampgonsalves]

Yes, sorry I was unclear, I meant that what you suggested is what airsonic does.

[sentriz]

ohh sorry yes. I misread :) if I did end up implementing ratings the way airsonic does. you could probably make a little script to update the gonic db's ratings for a given user and list of tracks

[davidhampgonsalves]

Yea I think I would do that. Also thanks for exposing gonicscan, really handy.

[sentriz]

also, looking at http://www.subsonic.org/pages/api.jsp "setRating"
this depends on #41
as pointed out: #41 (comment)
since the rating id can be a track, album, etc. and gonic uses primary keys for it's track, album, etc ids

[r0bbie]

Would supporting favouriting / starring songs come under this, or be a separate feature request?

[sentriz]

just merged the ambig ids branch. this feature should now be possible. eg handler

func (c *Controller) ServeSetRating(r *http.Request) *spec.Response {
    params := r.Context().Value(CtxParams).(params.Params)
    id, err := params.GetID("id")
    // handle err
    switch id.Type {
    case specid.Artist:
        // rate artist
    case specid.Album:
        // rate album
    case specid.Track:
        // rate track
    }
}

hey @r0bbie they're not exactly the same of but very similar to implement (mostly copy paste >:))

[sentriz]

closing in favour of #171

[sentriz]

ratings and stars are now shipped in master / :nightly . thanks to @brian-doherty

next release hopefully soon:
https://github.com/sentriz/gonic/milestone/1