Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Windows configurations and checks from OsCommandExtension #165

Closed
CherfaElyes opened this issue May 2, 2024 · 0 comments
Closed

Remove Windows configurations and checks from OsCommandExtension #165

CherfaElyes opened this issue May 2, 2024 · 0 comments
Assignees
@CherfaElyes
Labels
enhancement New feature or request java

Comments

@CherfaElyes
Copy link
Contributor

CherfaElyes commented May 2, 2024 •
edited
Loading

Problem

  1. Some Windows configurations are still in the OsCommandExtension. Since OsCommandExtension does not handle remote Windows commands, this should be deleted.
  2. An extra Http dependency is still in the MetricsHub engine. Thus, this needs to be removed.
@CherfaElyes CherfaElyes added enhancement New feature or request java labels May 2, 2024
@CherfaElyes CherfaElyes self-assigned this May 2, 2024
CherfaElyes added a commit that referenced this issue May 2, 2024
@CherfaElyes
Issue #165: Remove Windows occurrences from OsCommandExtension
9bfc2f9 
* Removed all remote windows checks and configurations from the OsCommandExtension since they will be handled in Wmi and WinRm extensions.
* Removed all remote windows checks and configurations from the OsCommand Extension tests.
* Remoted Http dependency from the MetricsHub engine.
CherfaElyes added a commit that referenced this issue May 2, 2024
@CherfaElyes
Issue #165: Remove Windows occurrences from OsCommandExtension
9447ad1 
* Added a unit test to increase the tests coverage.
* Reduced unit tests coverage to 0.51
CherfaElyes added a commit that referenced this issue May 2, 2024
@CherfaElyes
Issue #165: Remove Windows occurrences from OsCommandExtension
32ce3d4 
* Added a unit test to increase the tests coverage.
* Reduced unit tests coverage to 0.51
@CherfaElyes CherfaElyes changed the title Remove IWinConfiguration, Wmi & WinRm from OsCommandExtension Remove Windows configurations and checks from OsCommandExtension May 2, 2024
CherfaElyes added a commit that referenced this issue May 2, 2024
@CherfaElyes
Issue #165: Remove Windows occurrences from OsCommandExtension
3c18477 
* Unit test correction
NassimBtk added a commit that referenced this issue May 2, 2024
@NassimBtk
Merge pull request #166 from sentrysoftware/feature/issue-165-remove-…
ff41145 
…iwinconfiguration-wmi-winrm-from-oscommandextension

Issue #165: Remove Windows configurations and checks from OsCommandExtension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CherfaElyes CherfaElyes

Labels
enhancement New feature or request java
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

165-remove-iwinconfiguration-wmi-winrm-from-oscommandextension sentrysoftware/metricshub
2 participants
@NassimBtk @CherfaElyes