Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING_CHANGE] Disable automatic Hostname to FQDN resolution #433

Closed
NassimBtk opened this issue Sep 30, 2024 · 0 comments · Fixed by #434
Closed

[BREAKING_CHANGE] Disable automatic Hostname to FQDN resolution #433

NassimBtk opened this issue Sep 30, 2024 · 0 comments · Fixed by #434
Assignees
@NassimBtk
Labels
breaking_changes documentation Improvements or additions to documentation enhancement New feature or request
Milestone
v0.9.07

Comments

@NassimBtk
Copy link
Member

Description:
In the current implementation of the engine, the configured host.name attribute is automatically resolved to a fully qualified domain name (FQDN). The resolved host.name value is then attached to the OTEL Host resource, and each metric receives this resolved host.name attribute. If any issue arises during this resolution process, a new metric will be generated with a different host name.

Proposed Change:

  • By default, disable automatic resolution of host.name to FQDN.
  • Set the configuration property resolveHostnameToFqdn to failed by default.
    • If resolveHostnameToFqdn is set to true, the host.name will be resolved to FQDN, and the resolved value will be set in the OTEL Host resource.
    • If resolveHostnameToFqdn is set to false, the configured host.name will be used as-is to identify the OTEL Host resource, and it will be attached to each metric.

Impact:
This is a breaking change, as by default the system will no longer perform automatic FQDN resolution. Users relying on the current FQDN behavior must explicitly enable it using the configuration property resolveHostnameToFqdn: true in metricshub.yaml.
@NassimBtk NassimBtk added enhancement New feature or request breaking_changes labels Sep 30, 2024
@NassimBtk NassimBtk self-assigned this Sep 30, 2024
@NassimBtk NassimBtk added the documentation Improvements or additions to documentation label Sep 30, 2024
@NassimBtk NassimBtk changed the title [BREAKING_CHANGE] Disable automatic Hostname resolution to FQDN in MetricsHub [BREAKING_CHANGE] Disable automatic Hostname to FQDN resolution Sep 30, 2024
NassimBtk added a commit that referenced this issue Oct 1, 2024
@NassimBtk
Issue #433: Disable automatic Hostname to FQDN resolution
886caaa 
* Now the engine resolves FQDN based on `resolveHostnameToFqdn`.
* `resolveHostnameToFqdn` is set to false by default.
* Simplified Host Resource creation in the agent.
* Added `--resolve-fqdn` option to the CLI.
NassimBtk added a commit that referenced this issue Oct 1, 2024
@NassimBtk
Issue #433: Disable automatic Hostname to FQDN resolution
3312058 
* Now the engine resolves FQDN based on `resolveHostnameToFqdn`.
* `resolveHostnameToFqdn` is set to false by default.
* Simplified Host Resource creation in the agent.
* Added `--resolve-fqdn` option to the CLI.
* The Resource is now reported by the CLI.
NassimBtk added a commit that referenced this issue Oct 1, 2024
@NassimBtk
Issue #433: Disable automatic Hostname to FQDN resolution
faf89cb 
* Now the engine resolves FQDN based on `resolveHostnameToFqdn`.
* `resolveHostnameToFqdn` is set to false by default.
* Simplified Host Resource creation in the agent.
* Added `--resolve-fqdn` option to the CLI.
* The Resource is now reported by the CLI.
NassimBtk added a commit that referenced this issue Oct 1, 2024
@NassimBtk
Issue #433: Disable automatic Hostname to FQDN resolution
c75559e 
* Now the engine resolves FQDN based on `resolveHostnameToFqdn`.
* `resolveHostnameToFqdn` is set to false by default.
* Simplified Host Resource creation in the agent.
* Added `--resolve-fqdn` option to the CLI.
* The Resource is now reported by the CLI.
@NassimBtk NassimBtk linked a pull request Oct 1, 2024 that will close this issue
Issue #433: [BREAKING_CHANGE] Disable automatic Hostname to FQDN resolution #434
Merged
NassimBtk added a commit that referenced this issue Oct 2, 2024
@NassimBtk
Merge pull request #434 from sentrysoftware/feature/issue-433-breakin…
2affb96 
…g_change-disable-automatic-hostname-resolution-to-fqdn-in-metricshub

Issue #433: [BREAKING_CHANGE] Disable automatic Hostname to FQDN resolution
@NassimBtk NassimBtk added this to the v0.9.07 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NassimBtk NassimBtk

Labels
breaking_changes documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
v0.9.07
1 participant
@NassimBtk