-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to enable or disable self monitoring #518
Comments
I would name the configuration property |
We need to clarify where the
|
* Add enableSelfMonitoring in AgentConfig, ResourceConfiguration and ResourceGroupConfiguration * Transfer the new flag to HostConfiguration in Agent configuration helper * Add the flag to HostConfiguration * Update agent and engine tests * Refactor the method setJobDurationMetricInHostMonitor to include the new flag value check
* Change enableSelfMonitoring from Boolean.TRUE to true
…Job-duration-metric-configuration Issue #518: Enable job duration metric reporting through MetricsHub configuration
Job Duration Metrics Configuration
Summary
Enable users to configure the display of job duration metrics.
Description
Scenario 1: Job duration reporting is enabled (default or by configuration)
Given: A user has either enabled job duration reporting in the configuration or left the configuration unchanged (default setting).
When: Job duration reporting is active.
Then: The engine will compute and report job duration metrics to the OpenTelemetry Collector.
Scenario 2: Job duration reporting is explicitly disabled
Given: A user has explicitly disabled job duration reporting in the configuration.
When: Job duration reporting is inactive.
Then: The engine will not compute and report job duration metrics to the OpenTelemetry Collector.
Acceptance Criteria
Configuration for Job Duration Reporting
metricshub.yaml
file in the resource level or the resource group level or the configuration file root level:enableSelfMonitoring
true
Behavior When Enabled (Default Behavior)
enableSelfMonitoring: true
Behavior When Disabled
enableSelfMonitoring: false
Testing and Validation
Technical Specifications
MetricsHub Agent:
Add a private primitive boolean variable enableSelfMonitoring = "true"
Add a private Boolean Object variable enableSelfMonitoring
Add a private Boolean Object variable enableSelfMonitoring
Metricshub engine:
Add a check in
AbstractAllAtOnceStrategy
,CollectStrategy
,BeforeAllStrategy
andAfterAllStrategy
before callingsetJobDurationMetricInHostMonitor
:The text was updated successfully, but these errors were encountered: