Issue #203 : Refactor extensions code to check protocol efficiently #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated log4J2 async buffer and asyncLoggerWaitStrategy - Decreased large thread timeout 15 minutes
…o-check-protocol-efficiently
Fixed IpmiExtension
Fixed IpmiExtension fixed ProtocolHealthCheckStrategy
Fixed SnmpExtension
Fixed IpmiExtension
Fixed comments in HttpExtension and WmiExtension
SafaeAJ
changed the title
NassimBtk
requested changes
Jun 4, 2024
...ub-wmi-extension/src/main/java/org/sentrysoftware/metricshub/extension/wmi/WmiExtension.java
Outdated
Show resolved
Hide resolved
...http-extension/src/main/java/org/sentrysoftware/metricshub/extension/http/HttpExtension.java
Outdated
Show resolved
Hide resolved
...http-extension/src/main/java/org/sentrysoftware/metricshub/extension/http/HttpExtension.java
Outdated
Show resolved
Hide resolved
...ipmi-extension/src/main/java/org/sentrysoftware/metricshub/extension/ipmi/IpmiExtension.java
Outdated
Show resolved
Hide resolved
...ipmi-extension/src/main/java/org/sentrysoftware/metricshub/extension/ipmi/IpmiExtension.java
Outdated
Show resolved
Hide resolved
...rm-extension/src/main/java/org/sentrysoftware/metricshub/extension/winrm/WinRmExtension.java
Outdated
Show resolved
Hide resolved
...rm-extension/src/main/java/org/sentrysoftware/metricshub/extension/winrm/WinRmExtension.java
Outdated
Show resolved
Hide resolved
...ub-wmi-extension/src/main/java/org/sentrysoftware/metricshub/extension/wmi/WmiExtension.java
Outdated
Show resolved
Hide resolved
...wbem-extension/src/main/java/org/sentrysoftware/metricshub/extension/wbem/WbemExtension.java
Outdated
Show resolved
Hide resolved
...wbem-extension/src/main/java/org/sentrysoftware/metricshub/extension/wbem/WbemExtension.java
Outdated
Show resolved
Hide resolved
Modify checkProtocol method
Fixed OsCommandExtensionTest
Modify OsCommandExtensionTest and WbemExtensionTest
Modify ProtocolHealthCheckStrategy
Modify ProtocolHealthCheckStrategy
NassimBtk
requested changes
Jun 4, 2024
.../java/org/sentrysoftware/metricshub/engine/strategy/collect/ProtocolHealthCheckStrategy.java
Outdated
Show resolved
Hide resolved
...http-extension/src/main/java/org/sentrysoftware/metricshub/extension/http/HttpExtension.java
Outdated
Show resolved
Hide resolved
...http-extension/src/main/java/org/sentrysoftware/metricshub/extension/http/HttpExtension.java
Outdated
Show resolved
Hide resolved
...ipmi-extension/src/main/java/org/sentrysoftware/metricshub/extension/ipmi/IpmiExtension.java
Outdated
Show resolved
Hide resolved
...ping-extension/src/main/java/org/sentrysoftware/metricshub/extension/ping/PingExtension.java
Outdated
Show resolved
Hide resolved
...-extension/src/main/java/org/sentrysoftware/metricshub/extension/snmpv3/SnmpV3Extension.java
Outdated
Show resolved
Hide resolved
...wbem-extension/src/main/java/org/sentrysoftware/metricshub/extension/wbem/WbemExtension.java
Outdated
Show resolved
Hide resolved
...rm-extension/src/main/java/org/sentrysoftware/metricshub/extension/winrm/WinRmExtension.java
Show resolved
Hide resolved
...ub-wmi-extension/src/main/java/org/sentrysoftware/metricshub/extension/wmi/WmiExtension.java
Outdated
Show resolved
Hide resolved
.../java/org/sentrysoftware/metricshub/engine/strategy/collect/ProtocolHealthCheckStrategy.java
Outdated
Show resolved
Hide resolved
NassimBtk
requested changes
Jun 4, 2024
...sion/src/main/java/org/sentrysoftware/metricshub/extension/oscommand/OsCommandExtension.java
Outdated
Show resolved
Hide resolved
Modify log info in checkProtocol method
Fixed style in ProtocolHealthCheckStrategy
* Reverted untested changes
…tocol-efficiently' of https://github.com/sentrysoftware/metricshub.git into feature/issue-203-refactor-extensions-code-to-check-protocol-efficiently
NassimBtk
approved these changes
Jun 5, 2024
NassimBtk
deleted the
feature/issue-203-refactor-extensions-code-to-check-protocol-efficiently
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated WinRmExtension,
SnmpV3Extension,
SnmpExtension,
WmiExtension,
WbemExtension,
OsCommandExtension,
PingExtension,
IpmiExtension,
IProtocolExtension,
and ProtocolHealthCheckStrategy