Issue #523: hw.network.up metric not reported for WARN or ALARM states #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed LinkStatus state mapping.
NassimBtk
requested review from
MedMaalej,
bertysentry,
TNohaic and
CherfaElyes
CherfaElyes
approved these changes
Dec 18, 2024
bertysentry
approved these changes
Dec 18, 2024
NassimBtk
deleted the
feature/issue-523-hwnetworkup-metric-not-reported-for-connectors-with-link-state-as-warn-or-alarm
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed LinkStatus state mapping.
Details
This pull request includes changes to the
LinkStatusenum and the addition of a new test class to ensure the correct interpretation of state values. The most important changes include updating theLinkStatusenum to handle new states and adding a comprehensive test to verify the interpretation logic.Updates to
LinkStatusenum:metricshub-engine/src/main/java/org/sentrysoftware/metricshub/engine/common/helpers/state/LinkStatus.java: Added new states "warn" and "alarm" to theLinkStatusenum and updated the interpretation logic to classify these states asUNPLUGGED.Addition of test class:
metricshub-engine/src/test/java/org/sentrysoftware/metricshub/engine/common/helpers/state/LinkStatusTest.java: Added a new test classLinkStatusTestto verify the correct interpretation of various state values, including the newly added "warn" and "alarm" states.Testing
Before
Reported power: 378W
After
Reported power: 278W