Skip to content

Commit

Permalink
Rename "failures" to "failed" in qless-stats
Browse files Browse the repository at this point in the history
Graphite/whisper cannot have a name that serves both
as a metric name and as a dot-delimited prefix to
another metric. Because individual failure types are
reported as "failures.<type>", the "failures" metric
fails to be reported if ever there has been a report
of "failures.<type>". While this tool is not specific
to graphite, it is a common tool in the monitoring
ecosystem and it takes little effort to make this tool
compatible.
  • Loading branch information
Dan Lecocq committed Jan 16, 2018
1 parent 7cfe849 commit f3ced33
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion exe/qless-stats
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ class Stats < Thor
client.gauge "failures.#{failure}", count
count
end.reduce(0, :+)
client.gauge 'failures', total
client.gauge 'failed', total

# Track workers
client.gauge 'workers', qless.workers.counts.length
Expand Down
2 changes: 1 addition & 1 deletion lib/qless/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Encoding: utf-8

module Qless
VERSION = '0.11.0'
VERSION = '0.11.1'
end
2 changes: 1 addition & 1 deletion spec/integration/exe/qless_stats_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def get_statsd_messages
end

it 'tracks total failures' do
expect(messages).to include('failures:1|g')
expect(messages).to include('failed:1|g')
end

it 'tracks worker counts' do
Expand Down

0 comments on commit f3ced33

Please sign in to comment.