Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Travis container-based infrastructure. #268

Merged
merged 2 commits into from
Dec 30, 2017
Merged

Switch to Travis container-based infrastructure. #268

merged 2 commits into from
Dec 30, 2017

Conversation

b4hand
Copy link
Contributor

@b4hand b4hand commented Nov 21, 2017

No description provided.

@b4hand b4hand force-pushed the containerized-build branch 2 times, most recently from 2556635 to 72ff1f1 Compare December 22, 2017 22:05
@b4hand
Copy link
Contributor Author

b4hand commented Dec 22, 2017 •
edited
Loading

I've rebased this on top of #274 for now to get the latest stable Redis support to try to make the build pass. I'll rebase this again after #274 is merged.

@b4hand b4hand requested a review from GreyKn December 22, 2017 22:06
@b4hand b4hand force-pushed the containerized-build branch from 72ff1f1 to 750ab86 Compare December 23, 2017 20:46
@b4hand
Copy link
Contributor Author

b4hand commented Dec 28, 2017

Some of these tests appear to be a little fragile. I'm getting failures that pass on retries.

@b4hand
Copy link
Contributor Author

b4hand commented Dec 28, 2017

Build is now green. Can you take a look when you get a chance?

GreyKn
GreyKn approved these changes Dec 28, 2017
View reviewed changes
Copy link

@GreyKn GreyKn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. We should make note of the flapping tests and take care of them in a followup PR

@b4hand b4hand merged commit 7cfe849 into master Dec 30, 2017
@b4hand b4hand deleted the containerized-build branch December 30, 2017 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GreyKn GreyKn GreyKn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b4hand @GreyKn