Merge pull request #148 from seomoz/vinit-fix-npm-dep-bug

ROGER-2646 fix bug with private repo dependencies with branch or tag
seomoz · Mar 30, 2018 · 503a53d · 503a53d
2 parents b94be53 + 2242076
commit 503a53d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-0.4.18
+0.4.19
diff --git a/cli/docker_build.py b/cli/docker_build.py
@@ -160,9 +160,8 @@ def packagejson_swaparoo():
     # Do the swaparoo
     for name, version in data['dependencies'].items():
         if('git' in version or 'https' in version) and 'seomoz' in version:
-            data['dependencies'].pop(name, None)
-            print("popped {} as a private dependency".format(name))
-            os.system('npm install {}'.format(name))
+            print("popped {} as a private dependency".format(version))
+            os.system('npm install {}'.format(version))
 
     # Write modified
     with open('package.json', 'w+') as packagejson: