Messletters2 #109
Merged
Messletters2 #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #109 +/- ##
=======================================
Coverage 90.79% 90.79%
=======================================
Files 1 1
Lines 239 239
Branches 63 63
=======================================
Hits 217 217
Misses 19 19
Partials 3 3Continue to review full report at Codecov.
|
sadrasabouri
reviewed
Feb 6, 2020
.travis/install.sh
Outdated
| $PYTHON_COMMAND setup.py install | ||
| $PYTHON_COMMAND -m art test | ||
| $PYTHON_COMMAND -m art test2 | ||
| $PIP_COMMAND install -e .[Coverage] |
There was a problem hiding this comment.
What is this whole commit for?
Can you please explain the reason?
There was a problem hiding this comment.
First I added this line to test art library in develop mode, but later removed it ;-)
sadrasabouri
reviewed
Feb 6, 2020
.travis/test.sh
Outdated
| $PYTHON_COMMAND -m cProfile -s cumtime art_profile.py | ||
| $PIP_COMMAND uninstall art | ||
| $PIP_COMMAND install art --upgrade |
There was a problem hiding this comment.
Nope i might make mistake
sadrasabouri
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#101
What does this implement/fix? Explain your changes.
setup.pymodifiedcoveragedependency moved toextras_requirerequirements.txtremovedAny other comments?