Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-ASCII art filtered from random mode #110

Merged
merged 13 commits into from
Feb 13, 2020
Merged

Non-ASCII art filtered from random mode #110

merged 13 commits into from
Feb 13, 2020

Conversation

sepandhaghighi
Copy link
Owner

Reference Issues/PRs

#106

What does this implement/fix? Explain your changes.

  • NON_ASCII_ARTS list added
  • random mode modified
  • test parameter removed from font_list function
  • mode parameter added to font_list and art_list functions
  • Test system modified

Any other comments?

@sepandhaghighi sepandhaghighi added this to the art 4.6 milestone Feb 8, 2020
@codecov-io
Copy link

codecov-io commented Feb 8, 2020

Codecov Report

Merging #110 into dev will increase coverage by 0.66%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #110      +/-   ##
==========================================
+ Coverage   90.79%   91.46%   +0.66%     
==========================================
  Files           1        1              
  Lines         239      246       +7     
  Branches       63       66       +3     
==========================================
+ Hits          217      225       +8     
  Misses         19       19              
+ Partials        3        2       -1
Impacted Files Coverage Δ
art/art.py 91.46% <83.33%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb79b93...addbec4. Read the comment docs.

@sadrasabouri
Copy link
Collaborator

I think codecov test failure is due to lack of test for art_list function, isn't it?

@sepandhaghighi
Copy link
Owner Author

I think codecov test failure is due to lack of test for art_list function, isn't it?

@sadrasabouri

No, it's because of rearranging of tests (I moved all Non-ASCII tests to test2.py) -- > a3c7024 , 2acea82

Our total coverage increased to 91.46 ;-)

@sadrasabouri sadrasabouri merged commit bc53d15 into dev Feb 13, 2020
@sepandhaghighi sepandhaghighi deleted the Non-ASCII-Art branch March 2, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants