Font wizard enhancement #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #135 +/- ##
=======================================
Coverage 90.71% 90.71%
=======================================
Files 1 1
Lines 269 269
Branches 73 73
=======================================
Hits 244 244
Misses 23 23
Partials 2 2 Continue to review full report at Codecov.
|
sadrasabouri
reviewed
Oct 9, 2020
| print("\nThis font is {0}".format(ascii_flag)) | ||
| print("{}_dic = ".format(font_name),font_dic) | ||
| print("- Add this dictionary to the end of text_dic3.py") | ||
| print("- This font is {0} : ".format(ascii_flag)) |
There was a problem hiding this comment.
Considering next line if, is this line necessary?
There was a problem hiding this comment.
Why not?
I think it would be better if we show to user that this font is ASCII or not 💯
sadrasabouri
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#77
What does this implement/fix? Explain your changes.
font_wizard.pyscript updatedREADME.mdmodifiedAny other comments?