added space param to art and aprint functions #247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sepandhaghighi
requested changes
Jul 17, 2023
There was a problem hiding this comment.
@codewithnick Thanks for your efforts 💯
Please take a look at my comments 🔥
Also, you should rebase your dev branch. It's out of date and lead to some conflicts
CHANGELOG.md
Outdated
There was a problem hiding this comment.
@codewithnick What happened here?
3449 edits!!?
Please don't manipulate the file structure only add new logs.
art/art.py
Outdated
| @@ -125,7 +125,7 @@ def help_func(): | |||
| print(CLI_HELP) | |||
|
|
|||
|
|
|||
| def aprint(artname, number=1): | |||
| def aprint(artname, number=1,space=1): | |||
There was a problem hiding this comment.
Update aprint function docstring:
:param space: space between arts
:type space: int
art/art.py
Outdated
| except UnicodeEncodeError: | ||
| print(ART_ENVIRONMENT_WARNING.format(artname)) | ||
|
|
||
|
|
||
| def art(artname, number=1): | ||
| def art(artname, number=1,space=1): |
There was a problem hiding this comment.
Update art function docstring:
:param space: space between arts
:type space: int
art/art.py
Outdated
| @@ -174,7 +174,7 @@ def art(artname, number=1): | |||
| art_value = art_dic[artname] | |||
| if isinstance(number, int) is False: | |||
| raise artError(NUMBER_TYPE_ERROR) | |||
| return (art_value + " ") * number | |||
| return (art_value + " "*space) * number | |||
There was a problem hiding this comment.
PEP8:
return (art_value + " " * space) * number
art/art.py
Outdated
| except UnicodeEncodeError: | ||
| print(ART_ENVIRONMENT_WARNING.format(artname)) | ||
|
|
||
|
|
||
| def art(artname, number=1): | ||
| def art(artname, number=1,space=1): |
There was a problem hiding this comment.
PEP8:
def art(artname, number=1, space=1):
art/art.py
Outdated
| @@ -125,7 +125,7 @@ def help_func(): | |||
| print(CLI_HELP) | |||
|
|
|||
|
|
|||
| def aprint(artname, number=1): | |||
| def aprint(artname, number=1,space=1): | |||
There was a problem hiding this comment.
PEP8:
def aprint(artname, number=1, space=1):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#241
What does this implement/fix? Explain your changes.
I have added space parameter in art and aprint functions (default parameter : space=1)
Any other comments?