New fonts #68
Merged
New fonts #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #68 +/- ##
=====================================
Coverage 89.3% 89.3%
=====================================
Files 1 1
Lines 243 243
Branches 63 63
=====================================
Hits 217 217
Misses 23 23
Partials 3 3Continue to review full report at Codecov.
|
| 12. contouring3 | ||
| 13. contouring4 | ||
| 14. love2 | ||
| - `get_font_dic` function |
There was a problem hiding this comment.
Thank you for this 🤝
| @@ -68,10 +68,12 @@ def print_result(flag_list, message_list): | |||
| for font1 in Font_List: | |||
| for font2 in Font_List: | |||
| if Font_List.index(font1) < Font_List.index(font2): | |||
| if len(art.get_font_dic(font1)) == len(art.get_font_dic(font2)): | |||
| if len( | |||
There was a problem hiding this comment.
@sadrasabouri pep8 rule about max length of lines.
sadrasabouri
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#60 #59
What does this implement/fix? Explain your changes.
Add 5 new fonts :
Any other comments?