Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprezzkeyboard fonts #78

Merged
merged 18 commits into from
Nov 24, 2019
Merged

Sprezzkeyboard fonts #78

merged 18 commits into from
Nov 24, 2019

Conversation

sepandhaghighi
Copy link
Owner

Reference Issues/PRs

#74

What does this implement/fix? Explain your changes.

  • Add 10 new fonts :
    1. sarah
    2. hippie
    3. minion
    4. greek_legends
    5. funky_fresh
    6. atlantic
    7. foreign_friends
    8. native_lands
    9. sunday_cuddle
    10. chinese_mafia

Any other comments?

@codecov-io
Copy link

codecov-io commented Nov 23, 2019

Codecov Report

Merging #78 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #78   +/-   ##
=======================================
  Coverage   90.79%   90.79%           
=======================================
  Files           1        1           
  Lines         239      239           
  Branches       63       63           
=======================================
  Hits          217      217           
  Misses         19       19           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd3aeba...2726083. Read the comment docs.

Copy link
Collaborator

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been done perfectly!
But i can't understand the Codacy warning

@sepandhaghighi
Copy link
Owner Author

sepandhaghighi commented Nov 23, 2019

This PR has been done perfectly!
But i can't understand the Codacy warning

@sadrasabouri Thanks for your review
Codacy didn't have access to dev branch, it wasn't a major issue and solved ;-)
Note : I also made a small change in Codacy Code-Pattern

Copy link
Collaborator

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sadrasabouri sadrasabouri merged commit f387d21 into dev Nov 24, 2019
@sepandhaghighi sepandhaghighi deleted the sprezzkeyboard-fonts branch November 24, 2019 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants