Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert JSON numeric values to integers #82

Closed
tuxiqae opened this issue Jan 16, 2021 · 1 comment · Fixed by #100
Closed

Convert JSON numeric values to integers #82

tuxiqae opened this issue Jan 16, 2021 · 1 comment · Fixed by #100
Assignees
@sepandhaghighi
Labels
enhancement
Milestone
pyrgg 1.1

Comments

@tuxiqae
Copy link

tuxiqae commented Jan 16, 2021

Description

Currently when a new JSON graph is created all numeric values are written as strings even though they can be integers.

Expected Behavior

Have a JSON file with IDs, (including "source" and "target") as integers.

Actual Behavior

All those fields are strings

Pyrgg Version

v1.0
@sepandhaghighi
Copy link
Owner

@tuxiqae Good point 💯
We will work on this issue on a future release

@sepandhaghighi sepandhaghighi self-assigned this Mar 16, 2021
sepandhaghighi added a commit that referenced this issue Mar 24, 2021
@sepandhaghighi
fix : _write_nodes_to_json function modified #82
3db860e
sepandhaghighi added a commit that referenced this issue Mar 24, 2021
@sepandhaghighi
fix : _write_edges_to_json function modified #82
648b999
sepandhaghighi added a commit that referenced this issue Mar 24, 2021
@sepandhaghighi
fix : tests updated #82
f2018d6
sepandhaghighi added a commit that referenced this issue Mar 24, 2021
@sepandhaghighi
fix : tests updated #82
02b9fca
sepandhaghighi added a commit that referenced this issue Mar 24, 2021
@sepandhaghighi
doc : README formats section updated #82
2b4c15c
@sepandhaghighi sepandhaghighi added this to the pyrgg 1.1 milestone Mar 24, 2021
sepandhaghighi added a commit that referenced this issue Mar 24, 2021
@sepandhaghighi
doc : CHANGELOG updated #82
136243c
sepandhaghighi added a commit that referenced this issue Mar 24, 2021
@sepandhaghighi
doc : CHANGELOG updated #82
d5696b5
@sepandhaghighi sepandhaghighi mentioned this issue Mar 25, 2021
Merged
@sepandhaghighi sepandhaghighi mentioned this issue Jun 5, 2021
Merged
@sepandhaghighi sepandhaghighi linked a pull request Jun 5, 2021 that will close this issue
Version 1.1 #100
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sepandhaghighi sepandhaghighi

Labels
enhancement
Projects
None yet
Milestone
pyrgg 1.1
Development

Successfully merging a pull request may close this issue.

Version 1.1 sepandhaghighi/pyrgg
2 participants
@sepandhaghighi @tuxiqae