Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engines doc #169

Merged
merged 11 commits into from
Aug 7, 2024
Merged

Engines doc #169

merged 11 commits into from
Aug 7, 2024

Conversation

sepandhaghighi
Copy link
Owner

@sepandhaghighi sepandhaghighi commented Aug 4, 2024

Reference Issues/PRs

#145

What does this implement/fix? Explain your changes.

  • Engines section added to README.md
  • References section of README.md updated
  • Test system modified

Any other comments?

@sepandhaghighi sepandhaghighi self-assigned this Aug 5, 2024
@sepandhaghighi sepandhaghighi added this to the pyrgg 1.5 milestone Aug 5, 2024
@sepandhaghighi sepandhaghighi marked this pull request as ready for review August 5, 2024 08:57
Copy link
Collaborator

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny changes in documents that I guess may be useful.

README.md Outdated
</tr>
<tr>
<td align="center">Undirected / Directed</td>
<td align="center">Specifies whether the graph is undirected or directed</td>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

signed or unsigned reads better I guess.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in f5726fc

README.md Outdated
</tr>
<tr>
<td align="center">No Self Loop / Self Loop</td>
<td align="center">Specifies whether self-loops are not allowed or allowed</td>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about wether self-loop is allowed.?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 70562bd

README.md Outdated
</tr>
<tr>
<td align="center">Undirected / Directed</td>
<td align="center">Specifies whether the graph is undirected or directed</td>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

signed or unsigned reads better I guess.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in f5726fc

@sadrasabouri sadrasabouri merged commit 2a34e6a into dev Aug 7, 2024
45 checks passed
@sadrasabouri sadrasabouri deleted the engines branch August 7, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants