Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total Number of Edges #52

Merged
merged 6 commits into from
Aug 23, 2020
Merged

Total Number of Edges #52

merged 6 commits into from
Aug 23, 2020

Conversation

sepandhaghighi
Copy link
Owner

Reference Issues/PRs

#48 #49

What does this implement/fix? Explain your changes.

  • Minor edit in gexf_maker function spacing
  • Menu optimized

Any other comments?

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2020

Codecov Report

Merging #52 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #52   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files           3        3           
  Lines         421      421           
  Branches       68       68           
=======================================
  Hits          407      407           
  Misses         10       10           
  Partials        4        4           
Impacted Files Coverage Δ
pyrgg/params.py 100.00% <ø> (ø)
pyrgg/test.py 0.00% <ø> (ø)
pyrgg/pyrgg.py 97.07% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df74928...19e3ffb. Read the comment docs.

@@ -1306,47 +1306,47 @@ def gexf_maker(
weight_dic = dicts[1]
edge_number = dicts[2]
header = '<?xml version="1.0" encoding="UTF-8"?>\n'
header +='<gexf xmlns="http://www.gexf.net/1.2draft" version="1.2">\n'
header += '<gexf xmlns="http://www.gexf.net/1.2draft" version="1.2">\n'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this I've done it because it seemed more aligned in comparison with it's earlier line.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem ;-)
It's just a PEP8 rule

Comment on lines +1311 to +1314
meta = " " * 4 + '<meta lastmodifieddate="{0}">\n'.format(date)
meta += " " * 8 + '<creator>PyRGG</creator>\n'
meta += " " * 8 + '<description>{0}</description>\n'.format(file_name)
meta += " " * 4 + '</meta>\n'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -1268,7 +1268,7 @@
>>> input_dic['vertices']
20
>>> input_dic['min_edge']
19
20
Copy link
Collaborator

@sadrasabouri sadrasabouri Aug 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what it is this for?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a space to "Min Edge" and "Max Edge" in menu

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah

@sadrasabouri sadrasabouri self-requested a review August 23, 2020 14:08
@sadrasabouri sadrasabouri merged commit f61a005 into dev Aug 23, 2020
@sepandhaghighi sepandhaghighi deleted the edge_number branch August 23, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants