-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardized client interface #77
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LimpidCrypto
added
enhancement
New feature or request
XRPL Grants
This issue is planned to get resoled as part of the XRPL Grants program (within 8 months)
labels
Jun 9, 2024
…re is not satisfied error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
XRPL Grants
This issue is planned to get resoled as part of the XRPL Grants program (within 8 months)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR adds standardized traits to interact with the websocket clients and future JSON RPC Clients.
MessageHandler::handle_message
as tasktrait Client
Implements the request logic for each client.
trait AsyncClient
An external trait implemented for
T: embedded_io_async::Read + embedded_io_async::Write
orT: Stream<Output = String> + Sink<String>
. It calls the request implementation of theClient
trait.Context of Change
This is needed for #76 to be able to use
std
andno_std
clients with the high level methods.Type of Change
Test Plan