Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardized client interface #77

Merged
merged 23 commits into from
Jun 11, 2024
Merged

Conversation

LimpidCrypto
Copy link
Collaborator

@LimpidCrypto LimpidCrypto commented Jun 9, 2024

High Level Overview of Change

This PR adds standardized traits to interact with the websocket clients and future JSON RPC Clients.

  • Run MessageHandler::handle_message as task

trait Client

Implements the request logic for each client.

trait AsyncClient

An external trait implemented for T: embedded_io_async::Read + embedded_io_async::Write or T: Stream<Output = String> + Sink<String>. It calls the request implementation of the Client trait.

Context of Change

This is needed for #76 to be able to use std and no_std clients with the high level methods.

Type of Change

  • Refactor (non-breaking change that only restructures code)

Test Plan

@LimpidCrypto LimpidCrypto added enhancement New feature or request XRPL Grants This issue is planned to get resoled as part of the XRPL Grants program (within 8 months) labels Jun 9, 2024
@LimpidCrypto LimpidCrypto added this to the Add clients milestone Jun 9, 2024
@LimpidCrypto LimpidCrypto requested a review from sephynox as a code owner June 9, 2024 19:04
@LimpidCrypto LimpidCrypto changed the base branch from main to dev June 9, 2024 19:05
@LimpidCrypto LimpidCrypto merged commit db3e2aa into dev Jun 11, 2024
1 check passed
@LimpidCrypto LimpidCrypto deleted the standardized_client_interface branch September 8, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request XRPL Grants This issue is planned to get resoled as part of the XRPL Grants program (within 8 months)
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

1 participant