Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show names of files inside of encrypted archives (ZIP, RAR, 7Z), when available #1574

Open
wladimirleite opened this issue Mar 7, 2023 · 4 comments

Comments

@wladimirleite
Copy link
Member

If the file names are available (not also encrypted), they are not extracted in some situations.
From the tests I ran, the current behavior is:

  • ZIP: Only the first file name is shown (plus its parent folders, if present).
  • RAR: Nothing is extracted.
  • 7-ZIP: Names are extracted (in fact even subitems are created, with zero length). However, the "encrypted" property is not set.

Some sample files:
samples.zip

@lfcnassif
Copy link
Member

I thought ZIP behavior was the one you described for 7Z, maybe it changed at some point... Extracting empty subitems was the intended behavior in the past, at least for ZIP. I agree the "encrypted" flag should be set. Do you think we should change to just display subitem names in the Viewer or to always extract empty subitems with "encrypted" flag?

@wladimirleite
Copy link
Member Author

Do you think we should change to just display subitem names in the Viewer or to always extract empty subitems with "encrypted" flag?

Both would be fine for basic use cases (e.g. find these encrypted compressed files in searches using keywords), but I think extracting empty subitems may have more advantages (e.g. dates would be considered in the timeline).

I submitted a PR with the first option (for RARs only), just as a quick solution.

@lfcnassif
Copy link
Member

I think extracting empty subitems may have more advantages (e.g. dates would be considered in the timeline).

Another use case is searching for pthc just in name attribute, since it returns lots of false positives in file content, that would return those subitems but not the parent zip.

Anyway, if we manage to implement both, that would be better, right?

@wladimirleite
Copy link
Member Author

Another use case is searching for pthc just in name attribute, since it returns lots of false positives in file content, that would return those subitems but not the parent zip.

Good point!

Anyway, if we manage to implement both, that would be better, right?

Yes.

@wladimirleite wladimirleite removed their assignment Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants