-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show names of files inside of encrypted archives (ZIP, RAR, 7Z), when available #1574
Comments
I thought ZIP behavior was the one you described for 7Z, maybe it changed at some point... Extracting empty subitems was the intended behavior in the past, at least for ZIP. I agree the "encrypted" flag should be set. Do you think we should change to just display subitem names in the Viewer or to always extract empty subitems with "encrypted" flag? |
Both would be fine for basic use cases (e.g. find these encrypted compressed files in searches using keywords), but I think extracting empty subitems may have more advantages (e.g. dates would be considered in the timeline). I submitted a PR with the first option (for RARs only), just as a quick solution. |
Another use case is searching for Anyway, if we manage to implement both, that would be better, right? |
Good point!
Yes. |
If the file names are available (not also encrypted), they are not extracted in some situations.
From the tests I ran, the current behavior is:
Some sample files:
samples.zip
The text was updated successfully, but these errors were encountered: