Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Telegram iOS parser for UFDR and expose "extractMessages" parameter for Telegram Parser #2005

Closed
wladimirleite opened this issue Nov 30, 2023 · 4 comments · Fixed by #1999
Assignees

Comments

@wladimirleite
Copy link
Member

As discussed in #1999 (comment).

@wladimirleite
Copy link
Member Author

@lfcnassif, think a little bit more about this, wouldn't it make more sense to control which parser should be used (internal, external or both) per application (not globally as it is today using "phoneParsersToUse" parameter)?
For example, if I prefer the internal WhatsApp parser, but for Telegram I would like to use the external one...

Another point, I personally started using "all" sometime ago, and found it the best option, because I have already seen cases where an external parser brought some recovered message and that was not shown in internal parsed chats. And the opposite. Besides that, our WhatsApp parser shows some information not presented in the external parser.
The only inconvenience is the duplication of information. Not sure how to deal with this... maybe, it would help if WhatsApp chats (and any type of chat that has both parsing options, like Telegram) have two subcategories, for internally and externally parsed chats.

@lfcnassif
Copy link
Member

Hi @wladimirleite! Yes, I have already thought about this and I agree a per parser configuration, into ParserConfig.xml, would be better. We could create a forth possible value for phoneParsersToUse like dynamic or perApplication and use it by default.

About all results, I agree specific subcategories for internal and external would be clearer for users, especially for those that receive already processed cases.

@wladimirleite
Copy link
Member Author

Hi @wladimirleite! Yes, I have already thought about this and I agree a per parser configuration, into ParserConfig.xml, would be better. We could create a fourth possible value for phoneParsersToUse like dynamic or perApplication and use it by default.

About all results, I agree specific subcategories for internal and external would be clearer for users, especially for those that receive already processed cases.

Great! I think we should leave this for future issue, as the current PR (#1999) already mixed a few different things.

@lfcnassif
Copy link
Member

Closed by #1999.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants