Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to WhatsApp quoted messages in reply edited messages are not found #2245

Closed
gfd2020 opened this issue Jun 24, 2024 · 4 comments · Fixed by #2246
Closed

Jump to WhatsApp quoted messages in reply edited messages are not found #2245

gfd2020 opened this issue Jun 24, 2024 · 4 comments · Fixed by #2246
Assignees

Comments

@gfd2020
Copy link
Collaborator

gfd2020 commented Jun 24, 2024

The reference of a quoted message may be lost if the original message is edited.
As in the example below:
image

I've already found a way to get around this problem on New Android ( on IPhone I'm not sure if it happens). I'll make a PR.
I will need help with regression testing.

@gfd2020 gfd2020 self-assigned this Jun 24, 2024
@lfcnassif
Copy link
Member

Thanks @gfd2020 for reporting and taking a look at this!

@gfd2020
Copy link
Collaborator Author

gfd2020 commented Jun 24, 2024

Thanks @gfd2020 for reporting and taking a look at this!

Hi @lfcnassif .
I did a test here and it's already working. I implemented it in a way that shows the original message in the reply and has the reference to the jump. I think this way is the best of two worlds because you have the original text before editing and there is a jump to the edited message... what do you think?

image

@lfcnassif
Copy link
Member

what do you think?

Seems great!

@lfcnassif
Copy link
Member

Closed by #2246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants