Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jump quoted edited messages on whatsapp, add new message types, fix quoted status, quoted private and quoted catalog messages #2246

Open
wants to merge 51 commits into
base: master
Choose a base branch
from

Conversation

gfd2020
Copy link
Collaborator

@gfd2020 gfd2020 commented Jun 24, 2024

This PR fix Issue #2245 on Android New Databases.

Fix quoted status, privaty quote, catalog quote messages on Android New and IPhone.

Adds 2 new action types for Android:

*63 - Security code notifications are no longer available for this chat.

*142 - This group has over 256 members so now only admins can edit the groups settings.

*76 - You contacted this from find businesses

*69 - adds a subtype from table message_system_business_state

*Message type 15 and status equals 13 are deleted messages.

I haven't tested it on iPhone databases.
@wladimirleite , could you please help see this specific case on the iPhone?

@lfcnassif , I believe it would be good to do that batch of regression tests...

@gfd2020
Copy link
Collaborator Author

gfd2020 commented Jun 24, 2024

I think the edit timestamp information is not parsed on the iPhone, right?
In the iPhone databases that I have, I can't find any quote with editing...

@wladimirleite
Copy link
Member

wladimirleite commented Jun 24, 2024

I think the edit timestamp information is not parsed on the iPhone, right?

Right. I couldn't find any edit messages in the iPhones I was working on when implementing that feature, neither I have an iPhone that I can use to test.

@gfd2020
Copy link
Collaborator Author

gfd2020 commented Jun 26, 2024

@wladimirleite and @lfcnassif , I found 2 new action_types (android) that are not mapped, can I add them to this same PR?

@gfd2020 gfd2020 changed the title Fix jump quoted edited messages on whatsapp Fix jump quoted edited messages on whatsapp and add new message types Jun 26, 2024
@gfd2020 gfd2020 changed the title Fix jump quoted edited messages on whatsapp and add new message types Fix jump quoted edited messages on whatsapp, add new message types, fix quoted status messages Jun 27, 2024
@gfd2020
Copy link
Collaborator Author

gfd2020 commented Jun 27, 2024

I also implemented quoted status identification. I'm also seeing if I can implement quoted in particular in groups ...

I can´t find any quoted edited messagens on iphone to test 😥

@gfd2020
Copy link
Collaborator Author

gfd2020 commented Jun 28, 2024

Hi @lfcnassif and @wladimirleite .

I didn't know there were other types of citations (status and private). So these new types were implemented ( Android and Iphone):

"Quoted Status"
image

"Message quoted privately"
image

If user clicks on the quoted message:
image

"Message quoted privately not found"
image

"Quoted Catalog"
image

@gfd2020 gfd2020 changed the title Fix jump quoted edited messages on whatsapp, add new message types, fix quoted status messages Fix jump quoted edited messages on whatsapp, add new message types, fix quoted status and quoted private messages Jun 28, 2024
@gfd2020 gfd2020 changed the title Fix jump quoted edited messages on whatsapp, add new message types, fix quoted status and quoted private messages Fix jump quoted edited messages on whatsapp, add new message types, fix quoted status, quoted private and quoted catalog messages Jul 2, 2024
@lfcnassif lfcnassif added this to In progress in 4.2 via automation Jul 5, 2024
@lfcnassif
Copy link
Member

Thank you very much @gfd2020 for this PR!

@lfcnassif
Copy link
Member

A small regression test with 12 databases passed fine, running a larger one with hundreds of DBs...

@gfd2020
Copy link
Collaborator Author

gfd2020 commented Jul 29, 2024

Hi @lfcnassif .
I made a small commit to add translations ( french, italian and deutch) and to optimize a search. I added more information that can be captured in the iPhone case. I believe that this modification does not affect the database connection.

PS: Sorry for the additional commits, I was refining the code...

PS2: Just need to double check some things, change PR to Draft ..

@gfd2020 gfd2020 marked this pull request as draft July 29, 2024 23:47
@lfcnassif
Copy link
Member

Hi @lfcnassif . I made a small commit to add translations ( french, italian and deutch) and to optimize a search. I added more information that can be captured in the iPhone case. I believe that this modification does not affect the database connection.

PS: Sorry for the additional commits, I was refining the code...

PS2: Just need to double check some things, change PR to Draft ..

Thank you @gfd2020 for the additional improvements! Please don't worry. Just let me know when you finish, so I can re-run the regression tests again.

@gfd2020 gfd2020 marked this pull request as ready for review July 30, 2024 14:43
@gfd2020
Copy link
Collaborator Author

gfd2020 commented Jul 30, 2024

Hi @lfcnassif .

I just finish it. I was able to do comparison tests with a real database and a smartphone in the case of Android.
In the case of the iPhone, I only have the database, I don't have the device. It would be good if someone did a comparison test on the iPhone.

The logic behind implementing quotes can be quite confusing, so I left several comments in the code.

I don't know if the new messages in English have correct spelling. If anyone can review it too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
4.2
In progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants