-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix jump quoted edited messages on whatsapp, add new message types, fix quoted status, quoted private and quoted catalog messages #2246
base: master
Are you sure you want to change the base?
Conversation
I think the edit timestamp information is not parsed on the iPhone, right? |
Right. I couldn't find any edit messages in the iPhones I was working on when implementing that feature, neither I have an iPhone that I can use to test. |
@wladimirleite and @lfcnassif , I found 2 new action_types (android) that are not mapped, can I add them to this same PR? |
I also implemented quoted status identification. I'm also seeing if I can implement quoted in particular in groups ... I can´t find any quoted edited messagens on iphone to test 😥 |
Hi @lfcnassif and @wladimirleite . I didn't know there were other types of citations (status and private). So these new types were implemented ( Android and Iphone): If user clicks on the quoted message: |
…2020/IPED into fix-jump-quote-edit-messages
Thank you very much @gfd2020 for this PR! |
A small regression test with 12 databases passed fine, running a larger one with hundreds of DBs... |
Hi @lfcnassif . PS: Sorry for the additional commits, I was refining the code... PS2: Just need to double check some things, change PR to Draft .. |
Thank you @gfd2020 for the additional improvements! Please don't worry. Just let me know when you finish, so I can re-run the regression tests again. |
Hi @lfcnassif . I just finish it. I was able to do comparison tests with a real database and a smartphone in the case of Android. The logic behind implementing quotes can be quite confusing, so I left several comments in the code. I don't know if the new messages in English have correct spelling. If anyone can review it too... |
This PR fix Issue #2245 on Android New Databases.
Fix quoted status, privaty quote, catalog quote messages on Android New and IPhone.
Adds 2 new action types for Android:
*63 - Security code notifications are no longer available for this chat.
*142 - This group has over 256 members so now only admins can edit the groups settings.
*76 - You contacted this from find businesses
*69 - adds a subtype from table message_system_business_state
*Message type 15 and status equals 13 are deleted messages.
I haven't tested it on iPhone databases.
@wladimirleite , could you please help see this specific case on the iPhone?
@lfcnassif , I believe it would be good to do that batch of regression tests...