Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation for crypto wallets seed phrases #752

Closed
lfcnassif opened this issue Sep 10, 2021 · 1 comment
Closed

Validation for crypto wallets seed phrases #752

lfcnassif opened this issue Sep 10, 2021 · 1 comment
Assignees
@hauck-jvsh
Labels
enhancement

Comments

@lfcnassif
Copy link
Member

The regexes added in #558 are resulting in many false positives with the same word repeated multiple times (like: false false false false...). Checking this in a validator would decrease the number of false positives.
@hauck-jvsh hauck-jvsh self-assigned this Sep 10, 2021
hauck-jvsh added a commit that referenced this issue Sep 10, 2021
@hauck-jvsh
#752 the seed phrase is only valid if a single word is present less t…
7e6abb8 
…han 3 times;
@hauck-jvsh
Copy link
Member

#753 fix this problem

lfcnassif added a commit that referenced this issue Sep 15, 2021
@lfcnassif
#752: rename CRIPTO_SEED_PHRASE_EN to CRIPTO_POSSIBLE_SEED_PHRASE_EN
8ee84e5
lfcnassif added a commit that referenced this issue Oct 13, 2021
@lfcnassif
cherry pick #558 (just the EN regex) and #752 to 3.18.x branch
ec7ec15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hauck-jvsh hauck-jvsh

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lfcnassif @hauck-jvsh