-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Face cluster #1481
base: master
Are you sure you want to change the base?
Face cluster #1481
Conversation
…tem doesn't have a face
…compiled; Log the time spent extracting faces and the total time for grouping the faces;
Thank you @hauck-jvsh! Yes, #1185 is planned, I think it is needed for this and other features. |
I found the reason it is taking a lot of time during the process and not so much otherwise.
I think that it is creating a huge amount of threads and they are overwhelming the JVM. |
Actually it speed up the hole processing in this case. I think that the problem occurs when there is a lot of erros during the face extraction. |
Hum... very interesting! I think that block was created to read stderr of the created external processes to avoid blocking them if they write too many errors to stderr, possibly there is a better way to do this, maybe reusing the same Thread to read stderr of several processes, not sure how to implement it in python... |
Possibly the huge slowdown was caused by python GIL...
|
Actually that block is used to log stderr, not ignore it. |
Group similar faces and create a bookmark for each group. Maybe this could be enhanced if there is an API to change the itens, saving the group of each face in a metadata.
Closes #1475