-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow choosing Item Properties #1501
base: master
Are you sure you want to change the base?
Conversation
5c5bf10
to
6bb8201
Compare
Hi @lfcnassif, #52 and #286 may be almost finished here, but needs testing to see if this doesn't mess with previous working UI behaviour. It still has no limit to how many properties a user can choose for the html report, what should be the maximum? |
Thank you @FelipeFcosta! I'm not sure, maybe 100? Or maybe we could make it configurable in HtmlReportConfig.txt. Any opinion @tc-wleite? |
I am also not sure, but I think it is fine to have a hard coded limit like 100. I guess too many columns would make the report very hard to read. |
I added the 100 properties limit for the HTML report and the other functionalities. I think it's ready for review @lfcnassif |
Thank you @FelipeFcosta! I'll review this after 4.1 release, let's put this in 4.2. |
…el list in the report UI
For CSV export, I think there should be some basic metadata list, like "basicReportProps" in HTMLReportTask. Could be the same. These should always be exported, or, at least, a button to select them all should exists, like there is a button to 'select/ unselect all'. Maybe another checkbox with the name 'select/ unselect all basic props'. |
Isn't it replacing the tags? Could you fix it? |
Yes. I am fixing. |
It seems the problem was with my test config/environment. |
Yes. The problem was that I should had updated the templates of my case folder. It is working. |
Well, it seems it is working. I just want to make some suggestion, maybe to become new issue:
|
Those are good ideas, we just need to prioritize them looking at all other open issues... Are selected properties being saved in user.dir to be reused between different cases? If yes, user could select his preferred property set and the module could simply skip them if the specific item doesn't have the property, so a single list could work for all bookmarks/categories. |
No. They are saved in iped/data.
Em qua., 5 de abr. de 2023 12:27, Luis Filipe Nassif <
***@***.***> escreveu:
… Those are good ideas, we just need to prioritize them looking at all other
open issues...
Are selected properties being saved in user.dir to be reused between
different cases? If yes, user could select his preferred property set and
the module could simply skip them if the specific item doesn't have the
property, so a single list could work for all bookmarks/categories.
—
Reply to this email directly, view it on GitHub
<#1501 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG247SZYIERTJ2567YNGV53W7WMQ5ANCNFSM6AAAAAAUPLCN7I>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
closes #52 and #286