Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2011: Use group identifier as Communication:To in group messages #2268

Merged
merged 9 commits into from
Aug 2, 2024

Conversation

lfcnassif
Copy link
Member

@lfcnassif lfcnassif commented Jul 26, 2024

Closes #2011. This can have a big impact in case disk size and processing time when groups with many members and messages are decoded from IM applications.

I would like someone else to review this, since it will change the output of some chat decoders (Telegram, WhatsApp, Threema, Discord, Skype, UFDR imported chats).

@hauck-jvsh could you take a look after you return from vacation?

@aberenguel, could you test this with the UFDR you mentioned on #2011?

@lfcnassif
Copy link
Member Author

2 users tested this and it fixed the exponential time and space usage behavior with past cases which processing never finished.

@felipecampanini could you please confirm if commit 1d676d8 in DiscordParser is good? I used the Chat name as TO, not sure if it is fine, ideally it should be a discord forum/thread unique name/identifier, to avoid merging different groups/forums in the graph view as the same entity.

@patrickdalla could you please confirm if commit 53c5a3c in SkypeParser is fine?

@lfcnassif
Copy link
Member Author

Another user tested this PR and it worked fine, resulting in great processing time and case size reduction, like the other 2 users noticed, so I'm merging this. @felipecampanini and @patrickdalla, if groups identification in DiscordParser and SkypeParser could be improved, please let me know.

@lfcnassif lfcnassif merged commit d9dbe20 into master Aug 2, 2024
2 checks passed
@lfcnassif lfcnassif deleted the #2011_group_name_as_to branch August 2, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use group name as "Communication:To" in chat messages, instead of including each member
1 participant