Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1631: feature to select items and (subItems / parent / references / referencedBy) #2288

Merged
merged 16 commits into from
Nov 23, 2024

Conversation

aberenguel
Copy link
Contributor

…referencedBy)

@lfcnassif
Copy link
Member

Hi @aberenguel, thank you very very much for all your issue reports and fixing or enhancing PRs!

About this feature, do you know the Ctrl+A then Space key could be used to check all items into those related items tabs? Do you think it is not straightforward and are proposing an easier way to achieve the same thing?

@aberenguel
Copy link
Contributor Author

aberenguel commented Aug 16, 2024

Hi @aberenguel, thank you very very much for all your issue reports and fixing or enhancing PRs!

About this feature, do you know the Ctrl+A then Space key could be used to check all items into those related items tabs? Do you think it is not straightforward and are proposing an easier way to achieve the same thing?

I known. But I it is boring to do it thousand times. In my case, I have 2K images. What I wanted was to select all chats with those images.

@wladimirleite
Copy link
Member

I known. But I it is boring to do it thousand times. In my case, I have 2K images. What I wanted was to select all chats with those images.

The key point is that @aberenguel proposal allows dealing with multiple items at once, while the current procedure (described by @lfcnassif) must be repeated for each item, right?!

@lfcnassif
Copy link
Member

Oh I got it now, it checks all related items to all highlighted items in the main table, right? Sorry I didn't see the code changes yet and there is no issue describing the proposal in detail.

@lfcnassif lfcnassif linked an issue Aug 16, 2024 that may be closed by this pull request
@aberenguel
Copy link
Contributor Author

aberenguel commented Aug 20, 2024

h I got it now, it checks all related items to all highlighted items in the main table, r

That is it! The check is done for all highlighted items.
I used some shortcuts due to the previous use CTRL+R / ALT+R. But now the check functions are not bound to shortcuts anymore. I think the shortcuts (except CTRL+R / ALT+R) except could be removed.

@wladimirleite
Copy link
Member

@lfcnassif, do you think this PR should be included in the 4.2 release?
If that is the case, I can review it.

@lfcnassif
Copy link
Member

@lfcnassif, do you think this PR should be included in the 4.2 release?
If that is the case, I can review it.

Sure, we can include it! Thank you @wladimirleite and @aberenguel!

@wladimirleite wladimirleite self-requested a review October 19, 2024 12:03
@lfcnassif
Copy link
Member

lfcnassif commented Nov 19, 2024

Hi @wladimirleite! I know you are very busy, but do you still plan and have a time schedule to review this? I will be on vacation again starting on November 30th, and I plan to release IPED-4.2 just with the merged PRs before that time. It would be very nice if we could include this.

@wladimirleite
Copy link
Member

Hi @wladimirleite! I know you are very busy, but do you still plan and have a time schedule to review this? I will be on vacation again starting on November 30th, and I plan to release IPED-4.2 just with the merged PRs before that time. It would be very nice if we could include this.

Hi @lfcnassif!
I am sorry about the delay!
Unfortunately, the last few weeks have been very busy here.
I will finish this review by the end of the week.

Copy link
Member

@wladimirleite wladimirleite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were a lot of code changes (which I think improved the overall organization), so it is not easy to check everything, but as far as I can tell, looking at the code changes and doing some tests, this is ready to be merged.

I tested in a real case I am working on, and these new options were very useful.
Thanks @aberenguel!

Sorry again for the delay to finish the review.

@lfcnassif
Copy link
Member

Thank you @aberenguel for this feature and thank you @wladimirleite for your review!

@lfcnassif lfcnassif merged commit 13bcf5f into sepinf-inc:master Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu option to check highlighted items and parents
3 participants