-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1631: feature to select items and (subItems / parent / references / referencedBy) #2288
#1631: feature to select items and (subItems / parent / references / referencedBy) #2288
Conversation
…erences / referencedBy)
Hi @aberenguel, thank you very very much for all your issue reports and fixing or enhancing PRs! About this feature, do you know the Ctrl+A then Space key could be used to check all items into those related items tabs? Do you think it is not straightforward and are proposing an easier way to achieve the same thing? |
I known. But I it is boring to do it thousand times. In my case, I have 2K images. What I wanted was to select all chats with those images. |
The key point is that @aberenguel proposal allows dealing with multiple items at once, while the current procedure (described by @lfcnassif) must be repeated for each item, right?! |
Oh I got it now, it checks all related items to all highlighted items in the main table, right? Sorry I didn't see the code changes yet and there is no issue describing the proposal in detail. |
That is it! The check is done for all highlighted items. |
@lfcnassif, do you think this PR should be included in the 4.2 release? |
Sure, we can include it! Thank you @wladimirleite and @aberenguel! |
Hi @wladimirleite! I know you are very busy, but do you still plan and have a time schedule to review this? I will be on vacation again starting on November 30th, and I plan to release IPED-4.2 just with the merged PRs before that time. It would be very nice if we could include this. |
Hi @lfcnassif! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were a lot of code changes (which I think improved the overall organization), so it is not easy to check everything, but as far as I can tell, looking at the code changes and doing some tests, this is ready to be merged.
I tested in a real case I am working on, and these new options were very useful.
Thanks @aberenguel!
Sorry again for the delay to finish the review.
Thank you @aberenguel for this feature and thank you @wladimirleite for your review! |
…referencedBy)