Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes deployment page updates #50

Merged
merged 14 commits into from
May 16, 2024
Merged

Conversation

llewellyn-sl
Copy link
Contributor

Clean up install guide Kubernetes deployment page, consistent with previous updates to Docker Compose.

@llewellyn-sl llewellyn-sl added 1. Editor review Needs a language review 2. Dev/PM review Needs a review by a Dev or PM labels May 9, 2024
@llewellyn-sl llewellyn-sl self-assigned this May 9, 2024
Copy link

netlify bot commented May 9, 2024

Deploy Preview for seqera-docs ready!

Name Link
🔨 Latest commit fb1274f
🔍 Latest deploy log https://app.netlify.com/sites/seqera-docs/deploys/664662c5100dd40007d3c5cd
😎 Deploy Preview https://deploy-preview-50--seqera-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@adriannavarrobetrian adriannavarrobetrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@adriannavarrobetrian adriannavarrobetrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@justinegeffen justinegeffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great!

The only thing I would recommend is that in sections where there are only 2 numbered items, consolidate items 1 and 2 into two sentences without numbering (unless you can find a third item, in which case keep the numbering). From what I know, numbered lists should be at least 3 items (although that could be very old fashioned and I'm behind the times).

@llewellyn-sl llewellyn-sl added 4. Reviews complete Reviews complete. Remove label when confirmed in prod. and removed 1. Editor review Needs a language review 2. Dev/PM review Needs a review by a Dev or PM labels May 16, 2024
@llewellyn-sl llewellyn-sl merged commit 6b77246 into master May 16, 2024
5 checks passed
@llewellyn-sl llewellyn-sl deleted the k8s-deployment-updates branch May 16, 2024 19:54
@llewellyn-sl llewellyn-sl added done This issue is complete and removed 4. Reviews complete Reviews complete. Remove label when confirmed in prod. labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done This issue is complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants