Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tas 11/ Add command alias #158

Closed
wants to merge 4 commits into from
Closed

Tas 11/ Add command alias #158

wants to merge 4 commits into from

Conversation

grananda
Copy link
Contributor

No description provided.

@grananda grananda self-assigned this Nov 29, 2021
@grananda grananda linked an issue Nov 29, 2021 that may be closed by this pull request
Add subcommands alias #11
Open
@grananda grananda marked this pull request as ready for review November 29, 2021 13:12
@grananda grananda requested review from jordeu and swampie November 29, 2021 13:12
jordeu
jordeu requested changes Nov 30, 2021
View reviewed changes
Copy link
Member

@jordeu jordeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to the latest picocli 4.6.2. This was on hold because previous picocli version the autocomplete was not working properly with command alias, check that with the new version it is working.

@grananda
Copy link
Contributor Author

Autocomplete ok

image

@jordeu
Copy link
Member

jordeu commented Nov 30, 2021

No autocomplete it is not working for alias subcommands. You need to upgrade picocli
Screenshot from 2021-11-30 08-48-45
.

@jordeu
Copy link
Member

jordeu commented Nov 30, 2021

Oops, picocli v4.6.2 is not fixing this as expected. I'm going to convert this into a draft and remove the issue from current milestone.

@jordeu jordeu marked this pull request as draft November 30, 2021 11:30
@jordeu jordeu added the on hold label Nov 30, 2021
@jordeu
Copy link
Member

jordeu commented Dec 2, 2021

I'm going to close this PR. We can reopen it when picocli solves this problem.

@jordeu jordeu closed this Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordeu jordeu jordeu requested changes

@swampie swampie Awaiting requested review from swampie

Assignees

@grananda grananda

Labels
on hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add subcommands alias
2 participants
@grananda @jordeu