Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch with optimization turned off #424

Merged
merged 10 commits into from
Jul 22, 2024

Conversation

JaimeSeqLabs
Copy link
Contributor

Description

Closes #393

This PR adds support for disabling the optimized configuration when launching a pipeline by setting the --disable-optimization flag.

Guidelines for testing

  1. Create a new pipeline inside an organization workspace (optimization is available in non-personal workspaces only).
  2. Launch the pipeline once so the optimization becomes available.
    image
  3. Click on the light bulb and save the default optimization targets and values.
    image
  4. Verify that the pipeline is shown as optimized.
    image
  5. Launch the optimized pipeline and check that the configuration contains the optimized parameters.
    image
  6. Launch the optimized pipeline using ./tw with optimization turned off and check that the configuration does NOT contain the optimized parameters.
./tw launch HelloOptimization -w JaimeInc/Wsp --name=ThisShouldNotHaveOptimizations --disable-optimization

image

@pgeadas
Copy link
Contributor

pgeadas commented Jun 26, 2024

Do I need to do anything special to get the optimization available?

I created a pipeline inside a workspace and ran it, but still can't see the lamp.

@JaimeSeqLabs
Copy link
Contributor Author

JaimeSeqLabs commented Jun 28, 2024

I'm assuming you are running the pipeline in Seqera Platform (not in a local dev env)

Did the pipeline finish successfully?

I created a pipeline inside a workspace and ran it, but still can't see the lamp.

Is the lamp icon shown as unavailable or is it not shown at all?

@pgeadas
Copy link
Contributor

pgeadas commented Jun 28, 2024

I'm assuming you are running the pipeline in Seqera Platform (not in a local dev env)

It can't be ran locally?

@JaimeSeqLabs
Copy link
Contributor Author

JaimeSeqLabs commented Jun 28, 2024

It can't be ran locally?

It can, of course. But, given that tower-cli is a public repo, the test should be expected to run against prod so everyone can try it.

We can discuss offline the setup for the local instance.

@swampie
Copy link
Member

swampie commented Jul 19, 2024

tested! works fine!

…pport-via-cli

# Conflicts:
#	src/main/java/io/seqera/tower/cli/commands/runs/DumpCmd.java
@JaimeSeqLabs JaimeSeqLabs merged commit 7260a40 into master Jul 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable or disable pipeline optimization via CLI
3 participants