-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task 32 / Add pagination to list commands #72
Conversation
We need members and collaborators |
# Conflicts: # conf/reflect-config.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be nice to show that there are more items when you are not showing all the rows. But, if I'm not wrong, this is not possible because the API paginated response do not includes the total number of available rows. If this is the case, maybe it is worth to open an issue to track this problem at Tower API.
src/main/java/io/seqera/tower/cli/commands/members/ListCmd.java
Outdated
Show resolved
Hide resolved
src/main/java/io/seqera/tower/cli/commands/participants/ListCmd.java
Outdated
Show resolved
Hide resolved
src/main/java/io/seqera/tower/cli/commands/pipelines/ListCmd.java
Outdated
Show resolved
Hide resolved
src/main/java/io/seqera/tower/cli/commands/global/PaginationOptions.java
Outdated
Show resolved
Hide resolved
src/main/java/io/seqera/tower/cli/commands/global/PaginationOptions.java
Outdated
Show resolved
Hide resolved
src/main/java/io/seqera/tower/cli/commands/global/PaginationOptions.java
Outdated
Show resolved
Hide resolved
src/main/java/io/seqera/tower/cli/commands/global/PaginationOptions.java
Show resolved
Hide resolved
src/main/java/io/seqera/tower/cli/commands/global/PaginationOptions.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please add some tests about pagination? We could check that the urls are built correctly
# Conflicts: # src/main/java/io/seqera/tower/cli/commands/teams/AbstractTeamsCmd.java
Ok, I've seen that to add the If you don't set the
Which is not correct because the If we set We've hit this bug: remkop/picocli#1380 Maybe for now the solution can be to keep the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's implement the manual check to overcome the validate=false issue and then we are good to go for me
Closes #32