Add patch to allow inserting TF with same timestamp #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at-wat
reviewed
Sep 18, 2020
at-wat
reviewed
Sep 18, 2020
| diff --git a/tf2/src/cache.cpp b/tf2/src/cache.cpp | ||
| index f9614c7..3994ab2 100644 | ||
| --- a/tf2/src/cache.cpp | ||
| +++ b/tf2/src/cache.cpp |
There was a problem hiding this comment.
https://travis-ci.com/github/seqsense/aports-ros-experimental/jobs/386923791#L1523
This path seems be relative from geometry2 metapackage. tf2/ should be removed.
- The patch was generated relative the geometry2 metapackage whereas it should relative to the tf2 package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a short term patch to the ongoing issue in
tf2: ros/geometry2#467It enables the user to use TF with the behavior before this commit ros/geometry2@eefb509.
It can be turned on by setting
ALLOW_TF_REPEATEDtotrue.