Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update pipeline to use new wrappers #4

Merged
merged 1 commit into from
Feb 21, 2022
Merged

update pipeline to use new wrappers #4

merged 1 commit into from
Feb 21, 2022

Conversation

cokelaer
Copy link
Contributor

@cokelaer cokelaer commented Feb 18, 2022 •
edited
Loading

Fixes #3 #2

@cokelaer cokelaer requested review from khourhin and ddesvillechabrol and removed request for khourhin February 18, 2022 14:39
ddesvillechabrol
ddesvillechabrol approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@ddesvillechabrol ddesvillechabrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good pour moi, il restera plus qu'à enlever toutes les variables et les if qui encadrent les règles 😄

@cokelaer
update pipeline to use new wrappers
f8001c6 
applied black and add more comments
@cokelaer cokelaer merged commit 32ba505 into sequana:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddesvillechabrol ddesvillechabrol ddesvillechabrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactorisation using wrappers if possible
2 participants
@cokelaer @ddesvillechabrol