Add the hability to parse Glob and Folder path in modelPaths #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the usage of FS to GLOB. If the Path isn't a glob, it's a folder path and to work with glob, must be turned into a glob (by adding /* in the end). I think the check if it `hasMagic` should be an outside function, chained in a `map` before `arg.reduce`.
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
==========================================
+ Coverage 96.84% 96.85% +0.01%
==========================================
Files 100 100
Lines 918 921 +3
Branches 124 125 +1
==========================================
+ Hits 889 892 +3
Misses 9 9
Partials 20 20
Continue to review full report at Codecov.
|
|
@victorivens05 You could setup testing as follows:
|
|
@RobinBuschmann I created some tests, I'm not sure if they're enough. Now how do I add them to the PR? Or I have to create another? |
|
@victorivens05 Pushing you're changes to the remote branch of the PR should be enough :) Since you've created a PR from |
As suggested, I created 2 folders. In the first, all the files are already inside and should work normally. The other one has subfolders and must be matched via glob.
|
@victorivens05 Looks good 👍 I will merge it 🎉 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the usage of FS to GLOB. If the Path isn't a glob, it's a folder
path and to work with glob, must be turned into a glob (by adding /* in
the end).
I think the check if it
hasMagicshould be an outside function,chained in a
mapbeforearg.reduce.