Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm5 git support #202

Merged
merged 1 commit into from
Nov 20, 2017
Merged

Conversation

intellix
Copy link
Contributor

@intellix intellix commented Nov 20, 2017

Wanted to use my update but you haven't released it yet so would be nice to just install it directly from your git without the need to publish (something I miss from bower) :)

You can install the latest like:

npm i github:intellix/sequelize-typescript#npm5-git-support

@bilby91
Copy link
Contributor

bilby91 commented Nov 20, 2017

Hey @RobinBuschmann I think this is a better idea than the automatic release that we have been discussing.

npm docs state:

Git dependencies with prepare scripts will now have their devDependencies installed, and their prepare script executed as if under npm pack.

We would be only affecting users that install via git. I like this idea @intellix !

@codecov-io
Copy link

codecov-io commented Nov 20, 2017

Codecov Report

Merging #202 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #202   +/-   ##
=======================================
  Coverage   96.71%   96.71%           
=======================================
  Files         115      115           
  Lines        1004     1004           
  Branches      129      129           
=======================================
  Hits          971      971           
  Misses         15       15           
  Partials       18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ae4ca...7ac30eb. Read the comment docs.

@RobinBuschmann
Copy link
Member

Looks good! Let's do it!

@RobinBuschmann RobinBuschmann merged commit 67d720a into sequelize:master Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants