-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for all UUID versions #92
Conversation
2. Running the tests failed with an error message asking to install sqlite3 manually, so I did and it worked. When I installed manually it installed version 3.1.9, since it worked I kept the upgraded version.
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
=======================================
Coverage 95.65% 95.65%
=======================================
Files 66 66
Lines 759 759
Branches 106 106
=======================================
Hits 726 726
Misses 11 11
Partials 22 22
Continue to review full report at Codecov.
|
Looks good, thank you for implementing that. One question: You've updated |
@RobinBuschmann yes. It needed this change: |
@RobinBuschmann build and tests have failed on my machine. I tried the following
Got a failure (Don't remember what it was). Then I have tried to run: got an error, asking to install sqlite3 manually. So I ran:
This time it worked. I can open an issue for this, but wanna know if you have any ideas. |
@RobinBuschmann anything that is blocking this merge? |
Sequelize is using Validator to validates UUID strings.
Validator supports 4 versions of UUID - 3,4,5 and all:
https://github.com/chriso/validator.js/blob/b59133b1727b6af355b403a9a97a19226cceb34b/lib/isUUID.js#L14-L19
This change is updating IsUUID to support all possible options - 3,4,5 and all.
see DefinitelyTyped/DefinitelyTyped#18777 (comment)
Other stuff
Two additional changes:
WhereOptions
-->WhereOptions<any>
as IAssociationOptionsBelongsToMany
I am not sure about any of those additional changes. I know it passed compilation and testing, but I basically choose the option that compiles.
Also running
npm run build
before making any change failed. I have upgraded to node 8 and then it passed. Is there any dependency on the node version or it was just something locally on my machine?