Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge features into 7.1.x #250

Merged
merged 5 commits into from
Sep 22, 2022
Merged

Merge features into 7.1.x #250

merged 5 commits into from
Sep 22, 2022

Conversation

Findeton
Copy link
Contributor

No description provided.

edulix and others added 5 commits September 20, 2022 13:56
* adding support for login with otp-code field

* disabling user_id field for smart-link

Smart-link authentication method will be able to be done
by both the external application and Sequent IAM backend.

This means that Sequent will be able to verify the voter
authentication credentials. One of the credentials is the
user_id, which is a mandatory extra-field for smart-link
authnetication and comes from the auth-token received by
the external application. As such, it cannot be edited
by the user, and thus we are making it a filled-in and
disabled field in the login screen.

Future work will include allowing to hide a field and
showing it under a different name, to make mandatory
fields like user_id more user-friendly.

* fixing automatic request of otp code
* fix

* grunt build
bump angularjs versioN
* add html message

* common service var

* fix
@Findeton Findeton requested a review from edulix September 20, 2022 19:06
@edulix edulix self-requested a review September 21, 2022 08:52
Copy link
Contributor

@edulix edulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are changing version numbers here - we don't do that manually. We either use the release-script for that (it can be configured to change version and not do a release), or wait for a release in which we also change versions. We should keep the versions as is I think, so second option.

@Findeton Findeton merged commit b5671fb into 7.1.x Sep 22, 2022
@Findeton Findeton deleted the merge-features-71x branch September 22, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants