Initial Tendermint implementation #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also creates a dedicated file for the message log.
Ideally, this would be generic. Unfortunately, the generic API serde doesn't natively support borsh, nor SCALE, and while there is a serde SCALE crate, it's old. While it may be complete, it's not worth working with. While we could still grab bincode, and a variety of other formats, it wasn't worth it to go custom and for Serai, we'll be using SCALE almost everywhere anyways.
Greatly simplifies verifying when syncing.
Restores sig aggregation API.
For a hash, which is fixed-size, these should be the same yet this helps move past the dependency on SCALE. It also, for any type where the two values are different, smooths integration.
Also attempts to make the code more readable while updating/correcting documentation.
Greatly increases safety as well by ensuring only one message is processed at once.
1) Commit didn't include the round, leaving the clock in question. 2) Machines started with a local time, instead of a proper start time. 3) Machines immediately started the next block instead of waiting for the block time.
vrx00
reviewed
Nov 20, 2022
kayabaNerve
commented
Nov 20, 2022
Yanks tendermint-machine 0.1.0 accordingly.
Merges it into new. It has way too many arguments, yet there's no clear path at consolidation there, unfortunately. Additionally provides better scoping within itself.
Possible since it's only a single node, not requiring synchronization.
I really don't know what side effect this avoids and I can't say I care at this point.
|
LGTM 🔥 🔥 🔥 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't handle slashing nor staking.
With the new docker composition, the 6 nodes (3 validators, 3 nodes) are able to connect, produce blocks, and achieve finalizations over extended periods of time. I'm currently running such a config overnight to do initial tests on its stability.
Achieves the necessary handling of inherent transactions, enabling closing #47 for a series of smaller issues.