Skip to content

Commit

Permalink
Wrap confirmation and finality transactions into batch_all in Millau …
Browse files Browse the repository at this point in the history
…-> RialtoParachain bridge (paritytech#1898)

* wrap confirmation and finality transactions into batch_all in RialtoParachain<>Millau

* review comments
  • Loading branch information
svyatonik authored and serban300 committed Apr 10, 2024
1 parent 4150441 commit f5f2cc5
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,9 @@

use relay_millau_client::Millau;
use relay_rialto_parachain_client::RialtoParachain;
use substrate_relay_helper::messages_lane::{
DirectReceiveMessagesDeliveryProofCallBuilder, SubstrateMessageLane,
use substrate_relay_helper::{
messages_lane::{DirectReceiveMessagesDeliveryProofCallBuilder, SubstrateMessageLane},
UtilityPalletBatchCallBuilder,
};

substrate_relay_helper::generate_receive_message_proof_call_builder!(
Expand All @@ -45,6 +46,6 @@ impl SubstrateMessageLane for MillauMessagesToRialtoParachain {
millau_runtime::WithRialtoParachainMessagesInstance,
>;

type SourceBatchCallBuilder = ();
type SourceBatchCallBuilder = UtilityPalletBatchCallBuilder<Millau>;
type TargetBatchCallBuilder = ();
}
13 changes: 5 additions & 8 deletions bridges/relays/messages/src/message_race_loop.rs
Original file line number Diff line number Diff line change
Expand Up @@ -573,17 +573,14 @@ pub async fn run<P: MessageRace, SC: SourceClient<P>, TC: TargetClient<P>>(
if let Some((at_block, nonces_range, proof)) = race_state.nonces_to_submit.as_ref() {
log::debug!(
target: "bridge",
"Going to submit proof of messages in range {:?} to {} node",
"Going to submit proof of messages in range {:?} to {} node{}",
nonces_range,
P::target_name(),
target_batch_transaction.as_ref().map(|tx| format!(
". This transaction is batched with sending the proof for header {:?}.",
tx.required_header_id())
).unwrap_or_default(),
);
if let Some(ref target_batch_transaction) = target_batch_transaction {
log::debug!(
target: "bridge",
"This transaction is batched with sending the proof for header {:?}.",
target_batch_transaction.required_header_id(),
);
}

target_submit_proof.set(
race_target
Expand Down

0 comments on commit f5f2cc5

Please sign in to comment.