phpstan - return to production ver #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `...-x-dev` version was only used temporarily during an older PR 960 to get tests to pass. This PR simply resets it to normal. Described at: serbanghita#960 (comment)
|
It appears that Github Actions failed to properly download a functional phpunit package at the time this PR was submitted. Manually rerunning the tests will probably allow them to pass. |
|
thanks for this, I'll manually check it on local and retry the CI build |
|
@drbyte it looks like I also forgot to create a Docker specific run for [0] https://github.com/serbanghita/Mobile-Detect/blob/4.8.x/docker-compose.yml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
...-x-devversion was only used temporarily during an older PR 960 to get tests to pass.This PR simply resets it to normal.
Described at: #960 (comment)
Note: phpstan is only used by the tests, and is not required for Mobile-Detect to work.