Improve some crate::de::Deserialize impls by privately introducing CowBytes<'a>
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotree3
commented
Jun 10, 2020
| type Value = CowBytes<'de>; | ||
|
|
||
| fn expecting(&self, formatter: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| formatter.write_str("bytes") |
There was a problem hiding this comment.
Any ideas for a better message here?
| self.bytes | ||
| } | ||
|
|
||
| pub fn into_cow_bytes(self) -> Cow<'a, Bytes> { |
There was a problem hiding this comment.
Any ideas for a better name here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #23
Notably,
CowBytes<'a>is not publicly visible because it isn't re-exported at the crate-level like the other structs.Follow-up work would be to add proper trait impls and documentation and make the type public.
I haven't bothered to learn
serde_testand as such this introduces some untested code in thecowbytes.rsmodule. If that would block this PR I am happy to learn it and add the relevant tests.