Format f64 in error messages using ryu #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mingun
reviewed
Jan 27, 2024
Comment on lines
+469
to
+476
| match self.0 { | ||
| de::Unexpected::Unit => formatter.write_str("null"), | ||
| de::Unexpected::Float(value) => write!( | ||
| formatter, | ||
| "floating point `{}`", | ||
| ryu::Buffer::new().format(value), | ||
| ), | ||
| unexp => Display::fmt(&unexp, formatter), |
There was a problem hiding this comment.
I think, it would be good to add a comment why Float is processed differently to reduce count of WTF/min from readers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This produces a more readable representation using exponential notation for values that might be hundreds of digits when formatted by std::fmt.
It also includes trailing
.0on integer values (serde-rs/serde#2679).