Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use underscore consts on Rust 1.37+ #1827

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Use underscore consts on Rust 1.37+ #1827

merged 1 commit into from
Jun 19, 2020

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Jun 7, 2020

Fixes #1683

The error message for the code mentioned in rust-lang/rust#46991 is now as follows:

error[E0277]: the trait bound `S: _::_serde::Serialize` is not satisfied
  --> src/main.rs:14:5
     |
14   |     serde_json::to_string(&S);
     |                           ^^ the trait `_::_serde::Serialize` is not implemented for `S`
     |

@taiki-e taiki-e force-pushed the underscore_consts branch from 5f9fcff to b193b2d Compare June 7, 2020 05:41
@taiki-e taiki-e force-pushed the underscore_consts branch from b193b2d to a50e1c2 Compare June 19, 2020 06:56
dtolnay
dtolnay approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit b3ff7e4 into serde-rs:master Jun 19, 2020
@taiki-e taiki-e deleted the underscore_consts branch June 19, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use underscore consts on rustc 1.37+
2 participants
@taiki-e @dtolnay