Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ui test of unsatisfied serde trait bound #2769

Merged
merged 2 commits into from
Jul 6, 2024

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Jul 6, 2024

Test the diagnostic created by #2767.

|
= note: for local types consider adding `#[derive(serde::Serialize)]` to your `MyStruct` type
= note: for types from other crates check whether the crate offers a `serde` feature flag
= help: the following other types implement trait `Serialize`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LMAO wat. An exhaustive list of all impls

cc @estebank

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is from passing --verbose which is to work around error messages changing based on how many characters long the directory of your git checkout is, which affects the long type name truncation heuristic. See dtolnay/trybuild#269.

@dtolnay dtolnay merged commit 8cc4809 into serde-rs:master Jul 6, 2024
15 checks passed
@dtolnay dtolnay deleted the onunimpl branch July 6, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants