Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with non-native emoji output in demo app. #145

Merged
merged 1 commit into from
Nov 21, 2021

Conversation

serebrov
Copy link
Owner

When using custom emojis (like parrot), they are shown as 'undefined' in the output row:

Screenshot 2021-11-21 at 22 01 24

This PR adds another row, with Emoji components as output (also keeps the original row with native emojis, but inserts ? instead of undefined for emojis without native representation).

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2021

Codecov Report

Merging #145 (0c34d6b) into master (924e131) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   89.21%   89.21%           
=======================================
  Files          16       16           
  Lines         788      788           
  Branches      157      157           
=======================================
  Hits          703      703           
  Misses         79       79           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 924e131...0c34d6b. Read the comment docs.

@serebrov serebrov force-pushed the fix-docs-non-native-emoji-output branch from 1646f83 to 0c34d6b Compare November 21, 2021 20:07
@serebrov serebrov merged commit f9187a5 into master Nov 21, 2021
@serebrov serebrov deleted the fix-docs-non-native-emoji-output branch November 21, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants