Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update emoji's to emoji 14 #205

Merged

Conversation

Hysterelius
Copy link
Contributor

#203
This pull request is to update vue-emoji-mart to the latest Emoji v14 specification.

  • Updated data source URLs in css/emoji-mart.css to match Emoji v14
  • Data was rebuilt in data/ files with npm run build:data
  • Rebuilt dist/ files
  • In docs.app.vue:
  • Package-lock.json updated with npm
  • package.json updated to the latest emoji-datasource
  • In scripts/build.js, emoji-datasource updated their specifications to make all skin tones part of the category component instead of Skin Tones meaning that subcategory has to be used
  • In src/utils/emoji-data.js:

@serebrov
Copy link
Owner

serebrov commented Jul 3, 2022

@Hysterelius Thanks for the pull request. Is it ready for the review or are you going to do some more work here?

I see that tests are failing on CI. Can you go through and fix them? (if not: let me know, I'll do it myself later, looks like there are mostly non-functional failures).

Also: are there any limitations related to the update?
Previous emoji version upgrades had some breaking changes, do we have some breaking changes with this update?

@Hysterelius
Copy link
Contributor Author

@serebrov it is ready for review, that previous commit was just to fix up the prettier issues. I am happy to fix the tests. Yet to have found any breaking changes.

@serebrov serebrov changed the base branch from master to hystersis-update-emoji-to-v14 July 12, 2022 15:51
@serebrov
Copy link
Owner

serebrov commented Jul 12, 2022

Thanks! There are still some tests failing, I will merge this to a branch first, do more updates to tests and test it manually and release if everything is OK.

Update: correction: tests were fine, there was prettier complaint about formatting, fixed with npm run prettier.

@serebrov serebrov merged commit 0ac9be8 into serebrov:hystersis-update-emoji-to-v14 Jul 12, 2022
@serebrov serebrov mentioned this pull request Jul 12, 2022
@serebrov
Copy link
Owner

Published emoji-mart-vue-fast v11.0.0 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants