Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Susnux: feat emoji 15 #273

Merged
merged 7 commits into from
Jun 11, 2023
Merged

Susnux: feat emoji 15 #273

merged 7 commits into from
Jun 11, 2023

Conversation

serebrov
Copy link
Owner

A branch to test, merge, and release the original change from #270.

susnux and others added 2 commits June 5, 2023 16:01
Also adjusted the tests for the new emoji tiles

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2023

Codecov Report

Merging #273 (d0f6868) into master (f552fa1) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #273   +/-   ##
=======================================
  Coverage   89.42%   89.42%           
=======================================
  Files          15       15           
  Lines         577      577           
  Branches      143      143           
=======================================
  Hits          516      516           
  Misses         55       55           
  Partials        6        6           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@serebrov
Copy link
Owner Author

Testing it locally, everything looks good except google emojis: they seem to be shifted.

For example, native smiles:

Screenshot 2023-06-10 at 23 13 27

And google:

Screenshot 2023-06-10 at 23 13 50

@susnux
Copy link
Contributor

susnux commented Jun 11, 2023

Testing it locally, everything looks good except google emojis: they seem to be shifted.

This is known, I have submitted a patch. We need to update to version 15.0.1 :)

@serebrov
Copy link
Owner Author

Related: https://github.com/iamcal/emoji-data/pull/228/files and iamcal/emoji-data#226.

We actually already have v 15.0.1 in the package.json, but links in the CSS files pointed to 15.0.0, fixed in 7be8109

@serebrov serebrov merged commit f9352a4 into master Jun 11, 2023
@serebrov serebrov deleted the susnux-feat-emoji-15 branch June 11, 2023 14:47
@serebrov
Copy link
Owner Author

@susnux I published version 15.0.0 with emoji 15 update, thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants